From 11e9dbb33200d296050b285a402036ae6ad90644 Mon Sep 17 00:00:00 2001 From: Dakurei Date: Sat, 27 May 2023 22:08:39 +0200 Subject: [PATCH] Apply suggestions from code review Fix typo and newlines Co-authored-by: Adrien Smith --- .github/workflows/github-pages.yml | 2 +- .github/workflows/rspec.yml | 8 ++++---- .github/workflows/rubocop.yml | 6 +++--- .github/workflows/yard.yml | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml index 1e02f2d6b..a9def4743 100644 --- a/.github/workflows/github-pages.yml +++ b/.github/workflows/github-pages.yml @@ -62,4 +62,4 @@ jobs: cp -r /tmp/docs/. $GITHUB_REF_NAME git add $GITHUB_REF_NAME git commit --allow-empty -m "[skip ci] Deploy docs" - git push \ No newline at end of file + git push diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index 116be03ce..64ad119ad 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -1,4 +1,4 @@ -name: "Rspec" +name: "RSpec" on: push: @@ -10,7 +10,7 @@ on: jobs: rspec: - name: Rspec + name: RSpec runs-on: ubuntu-latest env: api-dir: ./ @@ -41,7 +41,7 @@ jobs: gem install bundler bundle install --jobs 4 --retry 3 - - name: Rspec spec (Ruby ${{ matrix.versions }}) + - name: RSpec spec (Ruby ${{ matrix.versions }}) working-directory: ${{env.api-dir}} run: bundle exec rspec spec --format progress --format RspecJunitFormatter -o ~/rspec/rspec.xml @@ -50,4 +50,4 @@ jobs: with: name: rspec_results_${{ matrix.versions }} path: ~/rspec/rspec.xml - retention-days: 30 \ No newline at end of file + retention-days: 30 diff --git a/.github/workflows/rubocop.yml b/.github/workflows/rubocop.yml index 597277770..bf1634633 100644 --- a/.github/workflows/rubocop.yml +++ b/.github/workflows/rubocop.yml @@ -1,4 +1,4 @@ -name: "Rubocop" +name: "RuboCop" on: push: @@ -10,7 +10,7 @@ on: jobs: rubocop: - name: Rubocop + name: RuboCop runs-on: ubuntu-latest env: api-dir: ./ @@ -34,6 +34,6 @@ jobs: gem install bundler bundle install --jobs 4 --retry 3 - - name: Rubocop checks + - name: RuboCop checks working-directory: ${{env.api-dir}} run: bundle exec rubocop diff --git a/.github/workflows/yard.yml b/.github/workflows/yard.yml index 2f7a263a4..1b7cea63f 100644 --- a/.github/workflows/yard.yml +++ b/.github/workflows/yard.yml @@ -48,4 +48,4 @@ jobs: with: name: docs_${{ github.run_number }} path: /tmp/docs.tar - retention-days: 30 \ No newline at end of file + retention-days: 30