Change method name to retrieve reactions from a channel message, and update support arguments

[joelzwarrington]

1. Discordrb::API::Channel.get_reactions, should be changed to #reactions to match other methods and ruby syntax.
2. before is not a supported argument¹
3. after should be optional, instead of being a required argument right now

discordrb/lib/discordrb/api/channel.rb

Line 203 in 4551619

def get_reactions(token, channel_id, message_id, emoji, before_id, after_id, limit = 100)

Footnotes

1. https://discord.com/developers/docs/resources/channel#get-reactions ↩

[Daniel-Worrall]

The api methods are 1:1 mappings on the API methods which is why it is named that way. Any renaming would also be a breaking change.

I also don't wish to see an alias for this, though this can be monkey-patched in any app that wishes to use this this way.

[joelzwarrington]

I think that the 1:1 mappings are inconsistent, as I've seen something like .message or .messages which is not a 1:1 mapping.

In my opinion, when building a Ruby client, you should try to use the same vocabulary/syntax that Ruby developers would expect. Of course this is only an opinion, but this is what I suggest to make it easier to understand and more 'ruby' like.

[Daniel-Worrall]

In the case of .message and .messages, these are legacy code and I'd be in favour of adding aliases to bring them more in line with the 1:1 mapping

https://github.com/shardlab/discordrb/blame/47bf48abea68164611321c9acbc6b24025daddad/lib/discordrb/api/channel.rb#L45