CI: add changelog check #2766
CI: add changelog check #2766
Conversation
cyqsimon
force-pushed
the
ci-check-changelog
branch
4 times, most recently
from
4db9716
to
9acb347
Compare
|
I apologise for the messy commit log. You may want to use squash merge 😅. |
|
No worries :) Feel free to force-push to fix it! After a first code review it can be good to avoid force push though, to make incremental review easier. This seems like a good idea, but we need to make an exception for auto-merged dependabot PRs. Example: #2761. Either based on branch (starts with |
cyqsimon
force-pushed
the
ci-check-changelog
branch
from
c869f59
to
dd41b6f
Compare
|
Rebased on |
Fetch the base branch and diff correctly - See: actions/checkout#160 Improve organisation Add some echo for easier debugging Fix bad variable syntax Clarify the double-print in the success case
cyqsimon
force-pushed
the
ci-check-changelog
branch
from
dd41b6f
to
8b12fba
Compare
|
|
|
Ah shit. I think I messed up. |
cyqsimon
force-pushed
the
ci-check-changelog
branch
3 times, most recently
from
fd311cc
to
eb09088
Compare
|
This is hard to verify before it's merged I suppose? So I'm tempted to merge it after you fix the comment so we can verify and iterate on it. |
|
Oh wait, right, it runs already (after you fix the bug) |
cyqsimon
force-pushed
the
ci-check-changelog
branch
from
eb09088
to
b54c88e
Compare
I made sure this workflow errors properly before I added the changelog for this PR. So if it passes now (as it should), I think it should be mostly fine. |
|
@cyqsimon Hi! Any chance you could fix a bug in the script? Right now it uses the last commit in a PR to determine author. That will give the wrong author if a maintainer adds a commit to the PR. We likely need to use Example of where the check fail when it shouldn't: #2779 |
|
Arrrrgh. There's always an edge case that slips by. I'll take a look. |
This workflow ensures that every PR has a corresponding entry in CHANGELOG.md that includes the PR number and the submitter ID.