Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocation heavy and get killed by OS #1063

Closed
Martinits opened this issue Jul 13, 2022 · 5 comments
Closed

allocation heavy and get killed by OS #1063

Martinits opened this issue Jul 13, 2022 · 5 comments
Labels

Comments

@Martinits
Copy link

Just run fd in / and it keeps allocating memory until OOM and gets killed. I often ran fd under / (actually through fzf for finding things under /). It wasn't like that before.
I'm using fd on archlinux, on a laptop with i7-8550U and 16G RAM.

❯ yay -Q fd
fd 8.4.0-1
@tavianator
Copy link
Collaborator

Dupe of #918 probably

@tavianator tavianator closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2022
@Martinits
Copy link
Author

Martinits commented Jul 13, 2022

But fd > /dev/null gets OOM on my system too, and my system is not that big(5TB?), about 50GB I think.
The point is such situation has NEVER happened before.

@tavianator
Copy link
Collaborator

I'm guessing that's just due to system performance differences. Since the queue is unbounded, the worker threads can generate paths faster than the receiver thread can read them. >/dev/null speeds up the receiver thread, but not necessarily by enough.

You can try my backpressure branch. If it still OOMs then it's a different bug, otherwise it's probably the same one.

@tavianator
Copy link
Collaborator

It's likely that 813a802 exacerbated this by increasing the size of the objects passed through the channel.

@Martinits
Copy link
Author

You can try my backpressure branch. If it still OOMs then it's a different bug, otherwise it's probably the same one.

Just tried this one, it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants