respect hidden file attribute

[ghost]

currently FD considers a hidden file something starting with ., which is a
long time Linux convention

However the Windows convention of the hidden file attribute is not recognized by
FD. So if you have some files on Windows with the hidden file attribute, FD will
always show them regardless of -H option, unless they also happen to start
with .

[colinwahl]

After briefly looking into this, it appears that fd uses ignore to walk the directory tree. It looks like the behavior you are describing stems from https://github.com/BurntSushi/ripgrep/blob/master/ignore/src/pathutil.rs#L20. Perhaps this issue should be raised there?

[sharkdp]

Thank you for the notice. We are going to include this as soon as the next ignore release is published.

[ghost]

@sharkdp I notice two ignore releases have been made since your comment:

• https://github.com/BurntSushi/ripgrep/releases/tag/ignore-0.4.8
• https://github.com/BurntSushi/ripgrep/releases/tag/ignore-0.4.7

[sharkdp]

Thank you for the reminder. Happy to include this into fd. We should probably also add a (Windows-only) test. I didn't look into how ignore implements this, but I think it would be reasonable to say that files starting with a dot would also be counted as "hidden" on Windows.

[ghost]

@sharkdp thats an interesting comment

i think its a difference between "hidden" and "dont show by default"

strictly speaking, dotfiles are not hidden by default on Windows. However most users probably dont care whats in them, and dont want them showing up in search results, in the general case. so if that means lumping dotfiles with true hidden files on windows, i am cool with that. but i think its an important distinction to make.

[sharkdp]

Handling of hidden files is now supported in v7.4.0.