Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd does not build inside termux on Android (aarch64) due to jemalloc usage #636

Closed
matu3ba opened this issue Aug 2, 2020 · 4 comments
Closed
Labels

Comments

@matu3ba
Copy link

matu3ba commented Aug 2, 2020

Describe the bug you encountered:
fd fails to build on aarch64

Describe what you expected to happen:
jemalloc not being used, so the build does not crash

What version of fd are you using?

8.1.1

Which operating system / distribution are you on?
Unix: Linux 4.4.226-lineageos aarch64 and no lsb_release (Android)

Appended logfile.

What kind of performance boost does jemalloc offer? Do you plan on supporting Android-like platforms?

@matu3ba matu3ba added the bug label Aug 2, 2020
@matu3ba
Copy link
Author

matu3ba commented Aug 2, 2020

err_install_fd.txt

@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2020

Do you plan on supporting Android-like platforms?

I'd be okay to merge changes if someone wants to work on that. Ideally, we should also add CI support for that platform. Otherwise we can not guarantee that things won't break in the future. I'm most probably not going to work on this myself.

What kind of performance boost does jemalloc offer?

See this blog post: https://dev.to/sharkdp/an-unexpected-performance-regression-11ai

@sharkdp
Copy link
Owner

sharkdp commented Oct 8, 2020

@matu3ba It would be great to get some feedback if the bug is fixed on master, thanks to the change by @fornwall.

@matu3ba
Copy link
Author

matu3ba commented Oct 9, 2020

@sharkdp This fixed the bug for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants