-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ignore .git/
by default
#1396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of including this change.
I left one small bit of feedback.
Co-authored-by: Thayne McCombs <[email protected]>
27c5700
to
9df9a48
Compare
Thank you for making this change. I'm also in favor of it. But I do think that this needs a bit of documentation and testing. I would suggest we adapt the As for the tests, I think we should at least add three simple checks that would assert that:
At least that is my understanding how this feature should work? |
Yup, that is how it should work. |
I'll write some tests and docs. |
Closes #1387 (breaking change!)
.git/
is now ignored by default even with--hidden
/-H
.Use
--no-ignore
/-I
or--no-ignore-vcs
to override.