Cygwin forward slashes #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hes if running in cygwin when output is not colorized
Absolutely not. Thank you very much for your contribution. Before going forward with this, I'd like to have the questions in #153 answered (also the ones by @ghuls), as it's not clear to me that we actually need this. Concerning the code changes, I'm not too keen about having so many |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#153
@sharkdp, I was messing around with this and figured I'd go ahead and open a PR, hope you don't mind. This change adds a check for if the HOME environment variable is present at run time on windows builds. The HOME environment variable is not available in cmd so it servers as a way to differentiate between the two environments and print the appropriate slashes accordingly.