Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more indicators #35

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Conversation

tavianator
Copy link
Contributor

@tavianator tavianator commented Sep 16, 2021

Partially addresses #6.

  • Tests

@tavianator
Copy link
Contributor Author

Hmm, the failed build is due to

could not find `stringify` in `_core`

@sharkdp
Copy link
Owner

sharkdp commented Sep 20, 2021

Thank you very much for working on this! I'm hoping to find some time to review it soon.

I guess the build error is already present on master. Pretty sure I've seen this before. Probably needs a MSRV upgrade.

@sharkdp
Copy link
Owner

sharkdp commented Oct 3, 2021

From a rough view, this looks very good. I'd be happy to integrate this if we can add the missing tests.

@sharkdp
Copy link
Owner

sharkdp commented Oct 3, 2021

I have migrated the project to GitHub Actions since Travis service has been discontinued. I rebased your branch. There is no build error anymore.

@tavianator tavianator marked this pull request as ready for review October 3, 2021 17:26
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work - thank you very much!

@sharkdp sharkdp merged commit dde45bf into sharkdp:master Oct 8, 2021
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 13, 2022
v8.3.1

Bugfixes
- Stop implying --no-ignore-parent when --no-vcs-ignore is supplied,
  see #907, #901, #908 (@tmccombs)
- fd no longer waits for the whole traversal if the only matches arrive within
  max_buffer_time, see #868 and #895 (@tavianator)
- --max-results=1 now immediately quits after the first result, see #867
- fd -h does not panic anymore when stdout is closed, see #897

Changes
- Disable jemalloc on FreeBSD, see #896 (@xanderio)
- Updated man page, see #912 (@rlue)
- Updated zsh completions, see #932 (@tmccombs)


v8.3.0

Performance improvements
- Colorized output is now significantly faster, see #720 and #853 (@tavianator)
- Writing to stdout is now buffered if the output does not go to a TTY. This
  increases performance when the output of fd is piped to another program or to
  a file, see #885 (@tmccombs, original implementation by @sourlemon207)
- File metadata is now cached between the different filters that require it
  (e.g. --owner, --size), reducing the number of stat syscalls when multiple
  filters are used; see #863 (@tavianator, original implementation by @alexmaco)

Features
- Don't buffer command output from --exec when using a single thread. See #522
- Add new -q, --quiet flag, see #303 (@Asha20)
- Add new --no-ignore-parent flag, see #787 (@will459)
- Add new --batch-size flag, see #410 (@devonhollowood)
- Add opposing command-line options, see #595 (@Asha20)
- Add support for more filesystem indicators in LS_COLORS, see
  sharkdp/lscolors#35 (@tavianator)

Bugfixes
- Always show the ./ prefix for search results unless the output is a TTY or
  --strip-cwd-prefix is set, see #760 and #861 (@jcaplan)
- Set default path separator to / in MSYS, see #537 and #730 (@aswild)
- fd cannot search files under a RAM disk, see #752
- fd doesn't show substituted drive on Windows, see #365
- Properly handle write errors to devices that are full, see #737
- Use local time zone for time functions (--change-newer-than,
  --change-older-than`), see #631 (@jacobmischka)
- Support --list-details on more platforms (like BusyBox), see #783
- The filters --owner, --size, and --changed-{within,before} now apply to
  symbolic links themselves, rather than the link target, except when
  --follow is specified; see #863
- Change time comparisons to be exclusive, see #794 (@jacobmischka)

Changes
- Apply custom --path-separator to commands run with --exec(-batch) and
  --list-details, see #697 (@aswild)

Other
- Many documentation updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants