Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefixes #8

Open
shashi opened this issue Aug 12, 2020 · 1 comment
Open

prefixes #8

shashi opened this issue Aug 12, 2020 · 1 comment

Comments

@shashi
Copy link
Owner

shashi commented Aug 12, 2020

There seems to be an idea of prefixes when it comes to paths, it could be an FTP or S3 URI.

It maybe useful and even improve code in this package to store this prefix at the root most node of a tree.

The obvious place for this is probably the parent field of the root node, which is set to nothing right now.

So the questions are

What should FileTree("foo") do? should it store foo as prefix and "." as the name? Or maybe "" as the name -- this needs more support.

@jpsamaroo
Copy link
Collaborator

As I said in Slack:

Maybe we'd have special types for ftp/s3/etc., which we could potentially dispatch on for differing behavior (like caching filesystem queries or something).

I agree with placing it in parent, although it doesn't necessarily need to point back to its children IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants