Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Change to which instead of whereis #220

Merged
merged 2 commits into from
Nov 4, 2018

Conversation

lachieh
Copy link
Contributor

@lachieh lachieh commented Oct 13, 2018

Removes the insecure dep whereis and changes to which. Functionality is a straight swap, so no changes need to be updated.

Fixes #208

@codecov-io
Copy link

codecov-io commented Oct 13, 2018

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          26       26           
  Lines         563      563           
  Branches      103       92   -11     
=======================================
  Hits          458      458           
+ Misses         84       81    -3     
- Partials       21       24    +3
Impacted Files Coverage Δ
packages/ssh-pool/src/commands/rsync.js 62.96% <100%> (ø) ⬆️
packages/ssh-pool/src/commands/tar.js 65.21% <0%> (ø) ⬆️
packages/ssh-pool/src/commands/raw.js 68.75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba6f00...6ef7638. Read the comment docs.

@gregberge gregberge merged commit 6f46cad into shipitjs:master Nov 4, 2018
@gregberge
Copy link
Member

Thanks!

@lachieh lachieh deleted the remove-whereis branch November 5, 2018 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants