Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Add keepWorkspace option #241

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

SleepWalker
Copy link
Contributor

This is a last portion of improvements to finally solve #207

I've added new config option, which will disable workspace deletion step and also documented two possible ways of configuring workspace path

@SleepWalker
Copy link
Contributor Author

@neoziro can you please take a look?

@gregberge
Copy link
Member

Hello @SleepWalker, it looks good but could you please try to make tests pass?

@SleepWalker
Copy link
Contributor Author

oh my, haven't noticed that :) It's now should be green (I hope)

@SleepWalker SleepWalker force-pushed the fix-no-workspace-flow branch 2 times, most recently from 3bf4fc5 to 604fbbf Compare July 15, 2019 05:26
@SleepWalker
Copy link
Contributor Author

@neoziro there is an issue because both shallowClone and workspace props set deploy config:

image

According to the logic before my PR, that workspace from config will be silently overridden with tmp dir, if shallowClone: true. I've removed that logic in my PR and if workspace config is set, than it has the biggest priority.

I'll revert this change and will log the warning, that workspace from config was overridden with tmp dir because of shallowClone option. This will be more clear to use and won't be a breaking change for existing users (and won't break tests too)

@SleepWalker SleepWalker force-pushed the fix-no-workspace-flow branch from 604fbbf to 8473912 Compare July 15, 2019 06:15
@gregberge gregberge merged commit c61d40d into shipitjs:master Jul 15, 2019
@gregberge
Copy link
Member

Thanks!

@SleepWalker SleepWalker deleted the fix-no-workspace-flow branch July 15, 2019 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants