Dead links in the readme

[jkeen]

The readme links to https://github.hubspot.com/tether/ for documentation, and those links are dead.

Not sure if you're managing http://tether.io/ now, but that site is loading weird too.

[RobbieTheWagner]

Definitely need to fix these. Not entirely sure how though.

[TrevorBurnham]

Not sure if you're managing http://tether.io/ now, but that site is loading weird too.

It looks OK from here. A network blip, perhaps?

[RobbieTheWagner]

@TrevorBurnham it's fully broken with a lot of 404. I think github.hubspot.com was perhaps removed?

[TrevorBurnham]

😕 Weird, https://github.hubspot.com/ loads just fine for me too…

[RobbieTheWagner]

@TrevorBurnham hmm, I think we mean https://github.hubspot.com/tether/ specifically.

[TrevorBurnham]

Looks like you already solved it: 69fa6af

[RobbieTheWagner]

@TrevorBurnham no, not solved yet. No idea how to solve all the 404s from http://tether.io/

There are a bunch of resources that are set to github.hubspot.com still and I don't know where those are coming from.

[TrevorBurnham]

There are a bunch of resources that are set to github.hubspot.com still and I don't know where those are coming from.

That domain is hard-coded into the Jade templates on the gh-pages branch, which all the HTML files are built from:

tether/resources/templates/base.jade

Lines 18 to 34 in 76e5760

	link(rel="stylesheet", href="http://github.hubspot.com/static-resources/css/print.css")
	link(rel="stylesheet", href="http://github.hubspot.com/static-resources/css/highlight-theme-github.css")
	link(rel="stylesheet", href="http://github.hubspot.com/static-resources/css/navigation-tweaks.css")
	link(rel="stylesheet", href="http://github.hubspot.com/static-resources/css/documentation.css")
	script(src="//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js")
	link(rel='stylesheet', href='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/CodeMirror/codemirror.css')
	link(rel='stylesheet', href='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/build/css/executr.css')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/CodeMirror/codemirror.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/CodeMirror/mode/coffeescript/coffeescript.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/CodeMirror/mode/javascript/javascript.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/coffee-script.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/underscore.min.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/lib/js2coffee.min.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/build/js/executr.js')
	script(src='//github.hubspot.com/#{ repo.name }/#{ root }/resources/executr/build/js/executr-run.js')

[RobbieTheWagner]

Ah thanks @TrevorBurnham! I did not realize those templates existed. That fixed the 404 issue, but now I think we're just hitting a lot of issues with Tether changes. Will try to fix it all soon.

[Desan]

@rwwagner90 it's still broken 🤔

[RobbieTheWagner]

@Desan yeah, haven't been able to figure out how to fix it

[RobbieTheWagner]

@TrevorBurnham any idea how hsdoc works? I keep trying to edit templates and building overwrites my changes.

[TrevorBurnham]

@rwwagner90 Hmm… sorry, it's a mystery to me too!

[RobbieTheWagner]

@TrevorBurnham any idea who we could ask?

[TrevorBurnham]

^ @zackbloom @adamschwartz Does this bring back memories for you? 😄

[zackbloom]

A trip down memory lane! hsdoc, as you can imagine, is a build tool on top of (I think?) grunt. Can we just change the domain in the built files like little cheaters, or do we need the build to work?

[RobbieTheWagner]

@zackbloom the hsdoc command seems to blow away all my changes every time. I'm trying to update base.jade but if I delete these two lines, they just come back when I run hsdoc -a https://github.com/shipshapecode/tether/blob/gh-pages/resources/templates/base.jade#L45-L46

I guess rather than using the jade templates we have defined here, hsdoc somehow has a default template setup that adds these things back again? I would like to be able to edit the jade templates without them being overwritten every time.

[zackbloom]

I wish I knew the answer, but I don't even have a copy of the hsdoc source anymore. The smart thing would probably be to port it to a more modern build chain, but I can't say how much work that would be.

[tilgovi]

Looks like tether.io maybe expired and got swooped up by the Tether crytocurrency project. It now redirects to tether.to.

[RobbieTheWagner]

We just moved to https://tetherjs.dev/