Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Conditions instead of Status in the BuildRun #307

Closed
qu1queee opened this issue Jul 24, 2020 · 3 comments · Fixed by #515
Closed

Move to Conditions instead of Status in the BuildRun #307

qu1queee opened this issue Jul 24, 2020 · 3 comments · Fixed by #515
Assignees
Labels
beta BETA related issue kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

Idea:

From previous community discussions, we would like to move out from having a Status on the Buildrun in favour of Conditions. This doc explains in detail why Conditions are a good practice in Kubernetes. Also, the Tekton TaskRun relies only on Conditions and their different fields are explained in here https://github.com/tektoncd/pipeline/blob/master/docs/taskruns.md#monitoring-execution-status

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 24, 2020
@gabemontero
Copy link
Member

gabemontero commented Jul 24, 2020

Some cross referencing

@qu1queee
Copy link
Contributor Author

qu1queee commented Nov 10, 2020

Updates on this:

Once both steps are done, we can close this issue.

@qu1queee
Copy link
Contributor Author

we are working now in step 2, to make the BuildRun to use the Conditions, wip branch is https://github.com/qu1queee/build/tree/br_conditions_imp, fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta BETA related issue kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants