-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject source via config map / secrets feature #48
Comments
Could you help me with a scenario, please? |
In this case I think our docs do a sufficient job of capturing this one. See https://docs.openshift.com/container-platform/4.3/builds/creating-build-inputs.html#builds-input-secrets-configmaps_creating-build-inputs |
Interesting use-case, @gabemontero. Putting myself as a final user, it would come handy to share common resources between different builds, therefore, it would act as another point of extensibility, which currently we only offer on Good idea, I think we should pursue it! |
/kind feature This would be useful in two contexts - dovetailing on the discussion in #419:
|
@adambkaplan I feel like we can either close this in favor of shipwright-io/community#23 and any items opened as a result of that, or we should cite this issue as something address by that SHIP, The former feels better but I'm enough on the fence to not hit the close button unilaterally Thoughts? |
There are a few subtle differences:
|
I'm not sure how the existing API or new api proposed in https://github.com/shipwright-io/community/blob/32b3d0f8f802d98a605bc2670fe2094229bdbb98/ships/0022-build-strategy-volumes.md would change based on your 2 points ^^ I have a guess or two perhaps, but instead, would it be feasible to construct yaml tweaks to either existing API or you proposed API to make it clear what you are getting at ? thanks |
Today openshift build v1 API allows for injection of config map content under the source tree of the build container for use during the image build
Do we want to expose a similar policy in build v2?
tekton tasks already allow for mounting of config maps / secret volumes in tasks/taskruns
The text was updated successfully, but these errors were encountered: