Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify registry credentials for build step #838

Open
HeavyWombat opened this issue Jul 21, 2021 · 2 comments
Open

Cannot specify registry credentials for build step #838

HeavyWombat opened this issue Jul 21, 2021 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@HeavyWombat
Copy link
Contributor

I think we have a gap in our setup for the following use case: You have a build that requires a specific container image (for example in the Dockerfile FROM statement), which is hosted in a private repository. We have no means to configure a secret with credentials to be used. If you happen to have configured the output image in the same registry, you get lucky as the container registry credentials for the output image are also used for pulling images. However, if they are different, it will not work. This could be especially interesting in case you hit the DockerHub rate limiting and want to have an authenticated pull from the registry.

@HeavyWombat HeavyWombat added the kind/bug Categorizes issue or PR as related to a bug. label Jul 21, 2021
@sbose78
Copy link
Member

sbose78 commented Jul 28, 2021

Brief discussion at grooming [sasha/shoubhik]:

  • Document using multiple credentials in the same secret, such that the secret is referenced in one of the existing API endpoints in the CRD.
  • Consider enhancing the CRD/API to have a section for taking in credentials for FROM image references.

@adambkaplan
Copy link
Member

adambkaplan commented Sep 22, 2021

Accepting this into the v1 backlog.

There is no immediate solution to this problem, so I recommend that whomever takes this up drafts a SHIP to propose a solution.

@adambkaplan adambkaplan added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 22, 2021
@adambkaplan adambkaplan added this to the release-v1.0.0 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants