I recently noticed that some links in the Shipwright documentation were pointing to 404 error pages. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shivamjaiswal424
changed the title
|
Apologies that we didn't get to this - it appears that we incorporated these changes in #140. Thanks for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that some links in the Shipwright documentation were pointing to 404 error pages, particularly in the sections for BuildStrategies and ClusterBuildStrategies. To resolve this issue, I made the following changes:
Updated the links to point to the correct files in the GitHub repository.
Ensured that both ClusterBuildStrategies and BuildStrategies sections now have accurate links to help users easily navigate to the relevant strategies.
For example, in the ClusterBuildStrategies section, I replaced the outdated relative links like ../samples/v1beta1/buildstrategy with the correct absolute links such as https://github.com/shipwright-io/build/tree/main/samples/v1beta1/buildstrategy.
This should make it easier for users to access the correct documentation without encountering broken links. Let me know if you have any questions or suggestions on further improvements!
Thanks,
Shivam Jaiswal
Changes
In the original doumentation of Shipwright it was difficult to find about the files of BuildStrategies and ClusterBuildStrategies.
I have added the correct links in their place.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Bug fixes