Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filtering objects in listing/counting methods inside ShortUrlRepository #1328

Closed
acelaya opened this issue Jan 16, 2022 · 0 comments · Fixed by #1337
Closed

Use filtering objects in listing/counting methods inside ShortUrlRepository #1328

acelaya opened this issue Jan 16, 2022 · 0 comments · Fixed by #1337
Labels
tech debt
Milestone
3.0.0

Comments

@acelaya
Copy link
Member

acelaya commented Jan 16, 2022

Those methods have a ton of arguments. Refactor them to use "filtering" DTOs (ShortUrlsListFiltering and ShortUrlsCountFiltering) like it's done with visits or tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Feature/short urls filtering acelaya-forks/shlink
1 participant
@acelaya