Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate config options objects to something that allows hydrating public readonly props #1492

Closed
acelaya opened this issue Aug 4, 2022 · 0 comments · Fixed by #1546
Closed
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Aug 4, 2022

Currently, all config options objects extend Laminas' AbstractOptions, which requires a setter to hydrate the properties, and therefore, a getter to ensure readonly access.

Find a way to hydrate objects via constructor to ensure all props can be set as public readonly.

@acelaya acelaya added this to the 3.3.0 milestone Aug 4, 2022
@acelaya acelaya reopened this Aug 6, 2022
@acelaya acelaya added this to Shlink Aug 8, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Aug 8, 2022
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Sep 17, 2022
@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Sep 17, 2022
Repository owner moved this from In review 👀 to Done ✅ in Shlink Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant