Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve typo on loosely short URL mode #1685

Closed
acelaya opened this issue Jan 29, 2023 · 0 comments · Fixed by #1686
Closed

Solve typo on loosely short URL mode #1685

acelaya opened this issue Jan 29, 2023 · 0 comments · Fixed by #1686
Labels
tech debt
Milestone
3.5.1

Comments

@acelaya
Copy link
Member

acelaya commented Jan 29, 2023

The new short URL mode introduced in Shlink 3.5.0 can have two values: strict or loosely, but the second one is actually not correct, it should be loose.

Add loose, deprecate loosely, and make loosely map to loose.
@acelaya acelaya added this to the 3.5.1 milestone Jan 29, 2023
@acelaya acelaya added this to Shlink Jan 29, 2023
@acelaya acelaya moved this to Todo 🗒️ in Shlink Jan 29, 2023
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Jan 29, 2023
@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Jan 29, 2023
@acelaya acelaya mentioned this issue Jan 29, 2023
Merged
@github-project-automation github-project-automation bot moved this from In review 👀 to Done ✅ in Shlink Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Shlink
Archived in project
Milestone
3.5.1
Development

Successfully merging a pull request may close this issue.

Rename loosely mode to loose mode acelaya-forks/shlink
1 participant
@acelaya