Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to roadrunner as the default runtime for docker images #1745

Closed
2 of 3 tasks
acelaya opened this issue Apr 11, 2023 · 0 comments · Fixed by #1775
Closed
2 of 3 tasks

Switch to roadrunner as the default runtime for docker images #1745

acelaya opened this issue Apr 11, 2023 · 0 comments · Fixed by #1775

Comments

@acelaya
Copy link
Member

acelaya commented Apr 11, 2023

There have been lately a couple of reports of hard to fix low-level issues that can only be reproduced with openswoole.

Additionally, roadrunner is easier to install and manage in general, while the performance is basically the same, so it probably makes sense to do the transition and recommend using roadrunner.

The list of reasons includes, but it's not limited to:

The only considerations are:

  • Roadrunner logs are not exactly the same as the ones generated by mezzio/mezzio-swoole when using openswoole. It would be good to get as close as possible.
    • The main missing feature is the request ID, but it doesn't seem to be supported by roadrunner.
  • It is possible to provide openswoole config via env vars, which is ignored by roadrunner. Would be good to see if something similar is possible with roadrunner. To be investigated in future if demanded.
  • The docker image is currently published with two flavors. No suffix uses openswoole, and -roadunner suffix uses roadrunner.
    • In order to keep BC, publish three versions from now on: No suffix has the "default" runtime, whichever it is. Then one suffixed tag is published for every specific runtime, warrantying that runtime will be used even if default one changes over time.
@acelaya acelaya added this to the 3.6.0 milestone Apr 11, 2023
@acelaya acelaya moved this to Todo in Shlink Apr 16, 2023
@acelaya acelaya moved this from Todo to In Progress in Shlink Apr 16, 2023
@acelaya acelaya moved this from In Progress to In review in Shlink May 7, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant