Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to use file secrets #1868

Closed
trexxeon opened this issue Sep 4, 2023 · 1 comment · Fixed by #1994
Closed

Add the option to use file secrets #1868

trexxeon opened this issue Sep 4, 2023 · 1 comment · Fixed by #1994
Labels
feature
Milestone
4.0.0

Comments

@trexxeon
Copy link

trexxeon commented Sep 4, 2023

Summary

As referred to in this thread: #1867 (comment)

I would like the ability to load the secrets via file secrets.

Use case

This would improve security.
@miralgj miralgj mentioned this issue Sep 20, 2023
Closed
@acelaya acelaya added this to the 4.0.0 milestone Nov 4, 2023
@acelaya acelaya moved this to Todo in Shlink Feb 1, 2024
@acelaya acelaya moved this from Todo to In Progress in Shlink Feb 9, 2024
@acelaya acelaya mentioned this issue Feb 10, 2024
Merged
@acelaya acelaya moved this from In Progress to In review in Shlink Feb 10, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Feb 10, 2024
@acelaya
Copy link
Member

acelaya commented Feb 10, 2024

This is now implemented. Shlink 4.0.0 will support the _FILE suffix on all supported env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
Shlink
Archived in project
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Support loading env vars from secret files acelaya-forks/shlink
2 participants
@acelaya @trexxeon