Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide some feedback when manually running visit:download-db without license key #1877

Closed
acelaya opened this issue Sep 17, 2023 · 0 comments · Fixed by #1926
Closed

Provide some feedback when manually running visit:download-db without license key #1877

acelaya opened this issue Sep 17, 2023 · 0 comments · Fixed by #1926
Labels
enhancement
Milestone
3.7.0

Comments

@acelaya
Copy link
Member

acelaya commented Sep 17, 2023

When running visit:download-db without providing a GeoLite license key, the exception thrown is swallowed and users don't know what went wrong.

Instead, this command should display a warning for users to know what's missing.

See #1841 (reply in thread)
@acelaya acelaya added this to the 3.7.0 milestone Nov 4, 2023
@acelaya acelaya moved this to Todo in Shlink Nov 4, 2023
@acelaya acelaya moved this from Todo to In Progress in Shlink Nov 23, 2023
@acelaya acelaya moved this from In Progress to Done in Shlink Nov 23, 2023
@acelaya acelaya moved this from Done to In review in Shlink Nov 23, 2023
@acelaya acelaya mentioned this issue Nov 23, 2023
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Shlink
Archived in project
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

Print a warning when manually running visit:download-db with no license acelaya-forks/shlink
1 participant
@acelaya