Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type property for Dynamic Redirection's Docs #2111

Closed
davidpiccinini opened this issue Apr 25, 2024 · 1 comment · Fixed by #2115
Closed

Wrong type property for Dynamic Redirection's Docs #2111

davidpiccinini opened this issue Apr 25, 2024 · 1 comment · Fixed by #2115
Labels
Milestone

Comments

@davidpiccinini
Copy link

Shlink version

4.x

PHP version

n/a

How do you serve Shlink

Docker image

Database engine

MySQL

Database version

5.7.39

Current behavior

Sample body for Dynamic Redirects is wrong, APi specs sample for that endpoint is wrong too. Condition property inside rule show JSON: { "type": "query", "matchKey": "hello", "matchValue": "world" } for a query key "hello" with value "world". API query returns 400 for that body.

Correct "type" property's value for queries is "query-param", discovered using CLI commands.

Please change to { "type": "query-param", "matchKey": "hello", "matchValue": "world" }

Expected behavior

Minimum steps to reproduce

@acelaya acelaya moved this to In Progress in Shlink Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Shlink Apr 29, 2024
@acelaya acelaya added this to the 4.1.1 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants