Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure right version is set when building docker image #2217

Closed
acelaya opened this issue Oct 11, 2024 · 1 comment
Closed

Make sure right version is set when building docker image #2217

acelaya opened this issue Oct 11, 2024 · 1 comment
Labels
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Oct 11, 2024

Shlink version

>=4.1.1

PHP version

How do you serve Shlink

Other (explain in summary)

Database engine

MySQL

Database version

Current behavior

The version passed and set in the app is the one used as docker tag, rather than the git tag.

This causes the version to potentially include a suffix, making the version no longer a valid SemVer pattern.

Expected behavior

All docker image expose a SemVer version pattern

Minimum steps to reproduce

Using any image with a roadrunner suffix, from Shlink 4.1.1 to 4.2.1, the health endpoint returns a version number which includes said suffix.

@acelaya acelaya added the bug label Oct 11, 2024
@acelaya acelaya added this to the 4.2.2 milestone Oct 11, 2024
@acelaya acelaya added this to Shlink Oct 11, 2024
@acelaya acelaya moved this to Todo in Shlink Oct 11, 2024
@acelaya acelaya removed the status in Shlink Oct 11, 2024
@acelaya acelaya moved this to Todo in Shlink Oct 11, 2024
@acelaya
Copy link
Member Author

acelaya commented Oct 13, 2024

Resolved by shlinkio/github-actions@a2843ef

@acelaya acelaya closed this as completed Oct 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Shlink Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant