Skip to content

Commit

Permalink
fix: fixed incorrect inside element resolution logic
Browse files Browse the repository at this point in the history
BREAKING CHANGE: previously if `inside` config property was not set (undefined) and viewContainerRef was supplied `inElement` resolved to true, now only if `inside` is explicitly true the modal is considered to be inside an element (i.e: inside the view container)

closes: #163
  • Loading branch information
Shlomi Assaf (shlassaf) committed Aug 22, 2016
1 parent c870560 commit 69895b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/angular2-modal/overlay/overlay.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class Overlay {
}

let dialog = new DialogRef<any>(this, config.context || {});
dialog.inElement = config.inside === undefined ? !!vcRef : !!config.inside;
dialog.inElement = !!config.inside;

let cmpRef = renderer.render(dialog, vcRef);

Expand Down

0 comments on commit 69895b6

Please sign in to comment.