Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not closing Angular 2 version 2.0 + Angular Cli beta 15 #208

Open
sudhishsasi opened this issue Sep 29, 2016 · 8 comments
Open

Modal not closing Angular 2 version 2.0 + Angular Cli beta 15 #208

sudhishsasi opened this issue Sep 29, 2016 · 8 comments

Comments

@sudhishsasi
Copy link

This was working fine in Angular RC4 and Angular Cli beta 10, after upgrading to Angular 2 version 2.0 + Angular Cli beta 15 modal pop is not closing and getting the below error. issue : #188 doesn't seems to be fixed.

EXCEPTION: Uncaught (in promise): undefined main.bundle.js:40494
ORIGINAL STACKTRACE: main.bundle.js:40499
Error: Uncaught (in promise): undefined
at resolvePromise (http://localhost:4200/main.bundle.js:71961:31)
at PromiseCompleter.reject (http://localhost:4200/main.bundle.js:71938:13)
at http://localhost:4200/main.bundle.js:62135:27
at ZoneDelegate.invokeTask (http://localhost:4200/main.bundle.js:71768:37)
at Object.NgZoneImpl.inner.inner.fork.onInvokeTask (http://localhost:4200/main.bundle.js:58242:37)
at ZoneDelegate.invokeTask (http://localhost:4200/main.bundle.js:71767:42)
at Zone.runTask (http://localhost:4200/main.bundle.js:71668:47)
at ZoneTask.invoke (http://localhost:4200/main.bundle.js:71836:33) main.bundle.js:40500
Error {stack: "Error: Uncaught (in promise): undefined↵ at res…e (http://localhost:4200/main.bundle.js:71836:33)", rejection: undefined, promise: ZoneAwarePromise, zone: Zone, task: ZoneTask…}

@shlomiassaf
Copy link
Owner

shlomiassaf commented Sep 29, 2016

#188 fixed, not released yet.

@naveenprincep
Copy link

Same issue. Its working fine in normal demo application but when it used this inside Angular-Cli beta 15, I am getting error when closing modal.

EXCEPTION: Uncaught (in promise): undefined
ErrorHandler.handleError @ main.bundle.js:41669
ORIGINAL STACKTRACE:
ErrorHandler.handleError @ main.bundle.js:41674
Error: Uncaught (in promise): undefined
at resolvePromise (main.bundle.js:76595)
at PromiseCompleter.reject (main.bundle.js:76572)
at main.bundle.js:64988
at ZoneDelegate.invokeTask (main.bundle.js:76402)
at Object.onInvokeTask (main.bundle.js:61286)
at ZoneDelegate.invokeTask (main.bundle.js:76401)
at Zone.runTask (main.bundle.js:76302)
at ZoneTask.invoke (main.bundle.js:76470)
ErrorHandler.handleError @ main.bundle.js:41675
Error: Uncaught (in promise): undefined(…)
consoleError @ main.bundle.js:76523

I tried #188 but its not fixing the issue. Maybe I am missing something. When will you release the next version?

@shlomiassaf
Copy link
Owner

@naveenprincep It should be released this week with AoT support for the CLI.
I hope it will go smooth :)

@naveenprincep
Copy link

naveenprincep commented Oct 3, 2016

@shlomiassaf Thanks for the fast release. I updated to new version but I am getting an error while initial loading

Uncaught SyntaxError: Unexpected identifier

Its pointing to
function arrayUnion(arr1, arr2) {
return arr1
.concat(arr2.filter(v => arr1.indexOf(v) === -1));
}

@sudhishsasi
Copy link
Author

Issue still exist in Angular cli beta 15 and 16.

@shlomiassaf
Copy link
Owner

I need to check that...

The new version now comes in 2 versions (in the same package)

  • ES5 1 file bundle UMD
  • ES6 modular version

I guess you'r setup is having issue dealing with the ES6 version, I need to check why.

If you are not using a module bundler that support ES6 imports it will automatically resolve to the UMD so you'r setup supports that but can't parse the file.

@naveenprincep
Copy link

naveenprincep commented Oct 12, 2016

@shlomiassaf Thanks. Now its building but getting the issue mentioned in #188

@naveenprincep
Copy link

#223 seems to fix the issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants