Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-black does not recognize all settings in pyproject.toml #9

Closed
tobiasraabe opened this issue Jun 24, 2018 · 3 comments
Closed

Comments

@tobiasraabe
Copy link

I have a pyproject.toml which includes the configuration of black. It seems that changing options like skip-string-normalization changes the test behaviour of pytest-black but keywords like include and exclude are not recognized. I assume that this behaviour is because pytest is responsible for file collection. Is it possible to make pytest aware of this additional configuration or do I have to duplicate the configuration from black and use the appropriate keywords in the pytest settings?

@paddycarey
Copy link

Hey Tobias, thanks for the report. I'm curious how other similar pytest plugins handle this case, let me check out a few and get back to you.

Seems like a reasonable addition, but I'd just like to verify we're doing the same thing as other plugins in this regard.

@tobiasraabe
Copy link
Author

tobiasraabe commented Jun 25, 2018

Hey Patrick,

I know of pytest-isort which faces the same issue and does not have a workaround either.

@paddycarey
Copy link

closed by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants