fix(tablesHeaderId): fix missmatch of option name

In code, the option appeared both as 'tableHeaderId' and 'tablesHeaderId', although only the first form had effect. In documentation was referenced as 'tablesHeaderId'. Option is now fixed in code to reflex the documentation and table parser accepts both forms, with and without an s. Closes #412
showdownjs · Aug 4, 2017 · 51e4693 · 51e4693
1 parent 1194d88
commit 51e4693
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 11 deletions.
diff --git a/dist/showdown.js b/dist/showdown.js
diff --git a/dist/showdown.js.map b/dist/showdown.js.map
diff --git a/dist/showdown.min.js b/dist/showdown.min.js
diff --git a/dist/showdown.min.js.map b/dist/showdown.min.js.map
diff --git a/src/subParsers/tables.js b/src/subParsers/tables.js
@@ -22,7 +22,8 @@ showdown.subParser('tables', function (text, options, globals) {
   function parseHeaders (header, style) {
     var id = '';
     header = header.trim();
-    if (options.tableHeaderId) {
+    // support both tablesHeaderId and tableHeaderId due to error in documention so we don't break backwards compatibility
+    if (options.tablesHeaderId || options.tableHeaderId) {
       id = ' id="' + header.replace(/ /g, '_').toLowerCase() + '"';
     }
     header = showdown.subParser('spanGamut')(header, options, globals);

diff --git a/test/node/testsuite.features.js b/test/node/testsuite.features.js
@@ -97,7 +97,7 @@ describe('makeHtml() features testsuite', function () {
         suite = tableSuite;
     for (var i = 0; i < suite.length; ++i) {
       if (suite[i].name === 'basic-with-header-ids') {
-        converter = new showdown.Converter({tables: true, tableHeaderId: true});
+        converter = new showdown.Converter({tables: true, tablesHeaderId: true});
       } else if (suite[i].name === '#179.parse-md-in-table-ths') {
         converter = new showdown.Converter({tables: true, strikethrough: true});
       } else {