-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(mentions): allow for usernames with dot, underscore and dash
Closes #574
- Loading branch information
Showing
9 changed files
with
28 additions
and
11 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
<p>hello <a href="https://github.com/tivie">@tivie</a> how are you?</p> | ||
<p>this email [email protected] is not parsed</p> | ||
<p>this @mentions is not parsed also</p> | ||
<p>this @mentions is not parsed</p> | ||
<p><a href="https://github.com/john.doe">@john.doe</a></p> | ||
<p><a href="https://github.com/john-doe">@john-doe</a></p> | ||
<p>@.johndoe</p> | ||
<p>@_johndoe</p> | ||
<p>@-johndoe</p> | ||
<p><a href="https://github.com/johndoe">@johndoe</a>.</p> | ||
<p><a href="https://github.com/johndoe">@johndoe</a>-</p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,18 @@ hello @tivie how are you? | |
|
||
this email [email protected] is not parsed | ||
|
||
this \@mentions is not parsed also | ||
this \@mentions is not parsed | ||
|
||
@john.doe | ||
|
||
@john-doe | ||
|
||
@.johndoe | ||
|
||
@_johndoe | ||
|
||
@-johndoe | ||
|
||
@johndoe. | ||
|
||
@johndoe- |
1 change: 0 additions & 1 deletion
1
test/functional/makehtml/cases/issues/#585.error-when-using-image-references.html
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
test/functional/makehtml/cases/issues/#585.error-when-using-image-references.md
This file was deleted.
Oops, something went wrong.