We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table rendering is no longer working with the latest version. With the test code:
var showdown = require('showdown'), converter = new showdown.Converter({tables: 'true'}), text = ['|key|value|', '|--|--|', '|My Key|My Value|'].join('\n'); html = converter.makeHtml(text); console.log(html);
The latest version showdown@^1.4.0 generates:
showdown@^1.4.0
<p>|key|value| |---|---| |My Key|My Value|</p>
The prior versionshowdown@~1.3.0 generates it correctly as:
showdown@~1.3.0
<table> <thead> <tr> <th>key</th> <th>value</th> </tr> </thead> <tbody> <tr> <td>My Key</td> <td>My Value</td> </tr> </tbody> </table>
The text was updated successfully, but these errors were encountered:
It seems the new tables regexes make table header separators require 3 dashes instead of 2.
This should work properly:
|key|value| |---|---| |My Key|My Value|
This behavior was not intended, and I will release a fix as soon as possible.
Sorry, something went wrong.
ddaacfc
Issue should be fixed now
New release for this fix https://github.com/showdownjs/showdown/releases/tag/1.4.1
Confirmed. Thanks!
tivie
No branches or pull requests
Table rendering is no longer working with the latest version. With the test code:
The latest version
showdown@^1.4.0
generates:The prior version
showdown@~1.3.0
generates it correctly as:The text was updated successfully, but these errors were encountered: