Markdown intercepts indented HTML blocks

[xduseko]

Deeply nested HTML tags are not rendered properly, markdown somehow intercepts.

<div>
  <div>
    <div>
      <div>
        text
      </div>
      <div>
        text
      </div>
    </div>
  </div>
</div>

Renders into

text
text
</div>

See codepen http://codepen.io/anon/pen/wJedgq

[obedm503]

remember that indentation affects how the markdown is rendered

http://codepen.io/anon/pen/aJwLBx

[xduseko]

It shouldn't be processed at all unless I use markdown attribute.

<div markdown>
  <div>
    <div>
      <div>
        text
      </div>
      <div>
        text
      </div>
    </div>
  </div>
</div>

[tivie]

This is indeed a bug but a hard one to tackle, due to efficiency constraints. I have a fix, but it slows down the parser considerably.

[tivie]

Until I can find a suitable fix, that doesn't slow down the parser too much, the workaround is not indenting html code.

[petebacondarwin]

Why do you have this ^ {0,3} constraint on the start tags?

showdown/src/subParsers/hashHTMLBlocks.js

Line 52 in 072973a

text = showdown.helper.replaceRecursiveRegExp(text, repFunc, '^ {0,3}<' + blockTags[i] + '\\b[^>]*>', '</' + blockTags[i] + '>', 'gim');

It can't be to avoid capturing indented code blocks as these are hashed away already, no?

[petebacondarwin]

Ah I see that indented code blocks are processed later.

[tivie]

Yes, they have to be processed AFTER HTML is hashed

[petebacondarwin]

@tivie - you talk about performance issues with your possible solution. Can you give me a pointer to how to run the performance tests as I would be interested in offering a PR for this issue but not if my solution also suffers from performance degradation.

[tivie]

If you install dev dependencies, you can run the command grunt performance and compare the results with previous implementations

[tivie]

Although performance degradation, in this case, is best seen with documents with "indented HTML".

[tivie]

This should (hopefully) be fixed now, without much performance issues.