Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI not working with jsdom v10 #554

Open
PotOfCoffee2Go opened this issue Jun 13, 2018 · 1 comment
Open

CLI not working with jsdom v10 #554

PotOfCoffee2Go opened this issue Jun 13, 2018 · 1 comment
Assignees

Comments

@PotOfCoffee2Go
Copy link

Freshly installed showdown npm install -g

showdown makehtml -i intro.md -o intro.html gets :

/home/kim/Desktop/projects/node/showdown/dist/showdown.js:585
  this.window = require('jsdom').jsdom('', {}).defaultView; // jshint ignore:line
                                 ^

TypeError: require(...).jsdom is not a function
    at Object.<anonymous> (/home/kim/Desktop/projects/node/showdown/dist/showdown.js:585:34)
    at Object.<anonymous> (/home/kim/Desktop/projects/node/showdown/dist/showdown.js:5090:4)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/kim/Desktop/projects/node/showdown/src/cli/makehtml.cmd.js:4:16)

When I change package.json "jsdom": "^10.0.0", to "jsdom": "^9.12.0",. - reinstall- and works ok.

So assume something to do when upgraded showdown from jsdom v9 to v10.

@tivie tivie self-assigned this Jun 14, 2018
@tivie
Copy link
Member

tivie commented Jun 14, 2018

thank you
I will look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants