use <s> over <del> for strikethroughs

[cbarraford]

Hello,
While <s> and <del> are very similar, they are not quite the same. And using <del> all the time for strikethrough text may not always make sense. I was wondering if I added a config option to allow us to specify which HTML tag to use for strikethroughs, would that PR be welcomed and merged in a timely manner?

[tivie]

Well, it depends. PRs are always welcome but I usually avoid merging PRs that introduce non standard new syntax elements, if hey are very different. What would be your strategy?

You should also note that showdown is currently in a "feature freeze", since version 2.0 is around the corner and the parser will suffer substantial refactoring.

If you wish to make a PR, that might get merged in a timely fashion, I would suggest doing it against version_1.x branch.

[cbarraford]

@tivie i was thinking we add a new config option called strikethroughTag which would default to del, to ensure complete backward compatibility. But someone could configure s (or something custom if they wanted). Thoughts?

[tivie]

In version 2.0, with the new template system, an option won't be needed as you would have full control over the output of the parser.

However, for version 1.x, that option would be very useful and pretty straightfoward. Also it won't impact in BC. So I don't why why not.

Please feel free to make a PR against the version 1.x branch. And if you throw a couple of test cases, I could merge as fast as possible.

[cbarraford]

@tivie any ETA on when v2 is being released?

[tivie]

http://showdownjs.com/#!/blog/rewriting-the-parser-challenges-and-opportunities