Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request/RFC: Add ability to read MR comments/make comments inside Vim #42

Open
leha-bot opened this issue Apr 3, 2023 · 3 comments

Comments

@leha-bot
Copy link

leha-bot commented Apr 3, 2023

It would be much convenient to avoid to open browser to see the reviewers commentaries for MRs.

Docs: https://docs.gitlab.com/ee/api/discussions.html

Kind regards,
Alex.

@shumphrey
Copy link
Owner

I'm open to PRs for stuff like this.
The hardest thing here is probably the UI, what does this look like?

There are a bunch of API functions in the code base, I don't think I currently have any for MR comments but they could be added.

PRs welcome.

@leha-bot
Copy link
Author

leha-bot commented May 3, 2023

Yes, I thought about UI. I may suggest a way with something like "lens" with inline comments for files which have been altered by MR; The active MR could be selected from gitlab API and current git branch. We may also jump from all (un)resolved conversations like in Gitlab web ui.
Also I think we may "steal" some UI features from vscode plugins 🤔
sorry if my ideas are "flaky", it's kind of rough drafts :)

@jakubbortlik
Copy link

Maybe this plugin would do what you need: https://github.com/harrisoncramer/gitlab.nvim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants