From 02567c29f524cbbeaaa59d58ba443824c70783fc Mon Sep 17 00:00:00 2001 From: leeanson19 Date: Sun, 16 Oct 2022 15:04:04 -0700 Subject: [PATCH 1/2] Fix async ping function --- promise.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/promise.js b/promise.js index fc74cc0c3a..4a9b0c0187 100644 --- a/promise.js +++ b/promise.js @@ -161,8 +161,18 @@ class PromiseConnection extends EventEmitter { const c = this.connection; const localErr = new Error(); return new this.Promise((resolve, reject) => { - const done = makeDoneCb(resolve, reject, localErr); - c.ping(done); + c.ping((err) => { + if (err) { + localErr.message = err.message; + localErr.code = err.code; + localErr.errno = err.errno; + localErr.sqlState = err.sqlState; + localErr.sqlMessage = err.sqlMessage; + reject(localErr); + } else { + resolve(true); + } + }); }); } From 128ebb4af8e39da4cc19ad3f7ecb67f742aca25d Mon Sep 17 00:00:00 2001 From: leeanson19 Date: Sun, 16 Oct 2022 15:21:15 -0700 Subject: [PATCH 2/2] Fix a small nit in ping function --- promise.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/promise.js b/promise.js index 4a9b0c0187..a264e77d5f 100644 --- a/promise.js +++ b/promise.js @@ -161,7 +161,7 @@ class PromiseConnection extends EventEmitter { const c = this.connection; const localErr = new Error(); return new this.Promise((resolve, reject) => { - c.ping((err) => { + c.ping(err => { if (err) { localErr.message = err.message; localErr.code = err.code;