Update SSL Profile for AWS Serverless Aurora #1026
Conversation
AWS Aurora Serverless instances use a different root certificate as noted here: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless.html#aurora-serverless.tls, specifically: https://www.amazontrust.com/repository/AmazonRootCA1.pem
|
Thanks @coreyjv !!! While you at this, can I ask you to compare with https://github.com/mysqljs/mysql/blob/master/lib/protocol/constants/ssl_profiles.js and check if anything else is missing? ( This file is used identically between mysqljs/mysq and node-mysql2, would be good to factor out this and maybe constants to external module some time later ) |
|
@sidorares -- The Aurora Serverless certificate does not exist in the mysqljs project either. Would it be more appropriate to create another PR that syncs this project with mysqljs so it's clearer or do you want it done prior to merging this one? |
|
Won't hurt to merge this one now and if you can do another against mysqljs that would be great - cc @dougwilson |
|
@sidorares -- I can certainly submit a PR to the mysqljs project as well. When can I expect this merge to land in a release? |
Mirror change to this project to align with the node-mysql2 PR here: sidorares/node-mysql2#1026
I recently merged really big change and also planning one more small but breaking so it has to be major version bump, so I'm planning to have -alpha1 published for some short time. I'll try to do that today/tomorrow and if no complaints publish release some time next week |
|
Awesome, thank you! |
AWS Aurora Serverless instances use a different root certificate as noted here:
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-serverless.html#aurora-serverless.tls,
specifically: https://www.amazontrust.com/repository/AmazonRootCA1.pem