Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems about charset #63

Open
bobchennan opened this issue Apr 14, 2012 · 6 comments
Open

problems about charset #63

bobchennan opened this issue Apr 14, 2012 · 6 comments

Comments

@bobchennan
Copy link

I have some problems about using charset-set. And after study,I found two bugs:

1.execute.js isn't support utf8;

2.charset.js isn't checking whether the str isn't string(for example, number)

And I have fix these bugs and commit here: nodejs-mysql-native

@sidorares
Copy link
Owner

Thanks!
looks good to me.
could you add simple test and create pull request?

@bobchennan
Copy link
Author

Yes, I will do it these days.

By the way, why don't you add this module to npm?

@sidorares
Copy link
Owner

@bobchennan
Copy link
Author

oh i see...

@bobchennan
Copy link
Author

I have sent pull request.

@sidorares
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants