Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write options to config by default #142

Open
actuday6418 opened this issue Sep 27, 2024 · 2 comments
Open

Do not write options to config by default #142

actuday6418 opened this issue Sep 27, 2024 · 2 comments

Comments

@actuday6418
Copy link

actuday6418 commented Sep 27, 2024

This is really unusual to a user who

  • Has iRust open in one window
  • Edits config.toml in another window
  • Closes and opens iRust
  • Sees changes to config have reverted

Saving config changes should be an explicit command.

@sigmaSd
Copy link
Owner

sigmaSd commented Sep 27, 2024

Thanks for the feedback, that makes sense

fixed in 1.71.24
the new explicit command is save_options

@sigmaSd sigmaSd closed this as completed Sep 27, 2024
@sigmaSd
Copy link
Owner

sigmaSd commented Oct 6, 2024

I ha to revert this because it interacted poorly with the options loading and the detection of first run of irust, I can it correctly when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants