Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Versioned Hashes During Optimistic Sync #4831

Closed
ethDreamer opened this issue Oct 11, 2023 · 1 comment
Closed

Validate Versioned Hashes During Optimistic Sync #4831

ethDreamer opened this issue Oct 11, 2023 · 1 comment
Assignees
@ethDreamer
Labels
deneb

Comments

@ethDreamer
Copy link
Member

Description

The consensus specs instruct us to verify the execution payload block_hash and versioned_hashes before sending engine_newPayload to the EE. This is because the EE could be syncing, putting us into optimistic sync mode. These checks only need to be performed during optimistic sync.

We already verify the block_hash and now we just need the versioned_hashes for deneb.
@ethDreamer ethDreamer self-assigned this Oct 11, 2023
@ethDreamer ethDreamer mentioned this issue Oct 11, 2023
Merged
@jimmygchen
Copy link
Member

Completed in #4832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethDreamer ethDreamer

Labels
deneb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimmygchen @ethDreamer