Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more builder_boost_factor settings in VC #5039

Closed
michaelsproul opened this issue Jan 8, 2024 · 5 comments
Closed

Expose more builder_boost_factor settings in VC #5039

michaelsproul opened this issue Jan 8, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request HTTP-API v4.6.0 ETA Q1 2024 val-client Relates to the validator client binary

Comments

@michaelsproul
Copy link
Member

Description

In #4813 we are adding the --produce-block-v3 flag for using the v3 block production APIs in the VC. We are supporting the existing builder_proposals: bool config for backwards compatibility, by translating builder_proposals: false to builder_boost_factor=0.

As described by @eserilev here (#4813 (comment)) it would be good to have some more expressive options in the VC like:

  • prefer_builder_proposals: bool: shorthand for builder_boost_factor=u64::MAX
  • builder_boost_factor: u64: support for other values configured on a per-validator basis

I don't think we necessarily need --local-always as this is what I was forced to translate builder_proposals: false to. If we deprecate builder_proposals then the "local always"/"prefer local" naming may be clearer.

@michaelsproul michaelsproul added enhancement New feature or request val-client Relates to the validator client binary HTTP-API labels Jan 8, 2024
@eserilev
Copy link
Collaborator

I'd like to pick this up

@michaelsproul
Copy link
Member Author

Thanks Eitan, it's all yours!

@paulhauner paulhauner added the v4.6.0 ETA Q1 2024 label Jan 18, 2024
@paulhauner
Copy link
Member

Heyo, we're lining up for a v4.6.0 release by Tuesday (23rd Jan) driven by the need to include the Deneb upgrades for Sepolia and Holesky.

One of the blockers on this release is reinstating --always-prefer-builder-payload. Our RocketPool friends rely on this flag, it's critical to them.

@eserilev, I appreciate this is a tight timeframe so we're happy to get this sorted internally if you don't have the time for this. We'd ideally need to have something ready for testing this week or Monday. No pressure from our end, just let us know 🙏

@eserilev
Copy link
Collaborator

@paulhauner i should have something ready for review in a few hours!

@jimmygchen
Copy link
Member

Completed in #5086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HTTP-API v4.6.0 ETA Q1 2024 val-client Relates to the validator client binary
Projects
None yet
Development

No branches or pull requests

4 participants