Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop lookups for blocks imported via range sync #5825

Open
dapplion opened this issue May 22, 2024 · 0 comments
Open

Drop lookups for blocks imported via range sync #5825

dapplion opened this issue May 22, 2024 · 0 comments

Comments

@dapplion
Copy link
Collaborator

Description

In recent testing of v5.2.0 we have observed cases where a lookup get stuck, range sync kicks in and catch up to the head.

However, sync lookup has no knowledge of the result of range sync and the lookup for an already imported block persists. We can make sync lookup aware of blocks imported via range sync and drop them.

This can help recover some situations faster, but it competes with

The PR above guarantees that every lookup that is stuck issues a very informative log and is tracked on metrics. If range sync can complete lookups we won't know with so much certainty if the lookup was stuck or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant