Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate in parallel #4

Closed
michaelsproul opened this issue Feb 3, 2022 · 2 comments
Closed

Iterate in parallel #4

michaelsproul opened this issue Feb 3, 2022 · 2 comments

Comments

@michaelsproul
Copy link
Member

I think it would be possible to implement Rayon's ParallelIterator for List and Vector so that we can alleviate some of the burden of tree iteration. Of course this only works for commutative operations like sums and we should be careful about introducing parallel iteration in consensus, as that has been a source of bugs in the past.
@michaelsproul
Copy link
Member Author

This is complicated by the move to top-level Interfaces which contain BTreeMaps. Combining the parallel BTreeMap iterator with the parallel iterator for the tree might be a bit of a pain

@michaelsproul
Copy link
Member Author

I'm less keen on this these days due to my misgivings about Rayon (see: sigp/lighthouse#4952).

Closing for now.

@michaelsproul michaelsproul closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul