Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of status codes. #35

Closed
AlbinLindskog opened this issue Dec 10, 2020 · 5 comments · Fixed by #36
Closed

Incorrect handling of status codes. #35

AlbinLindskog opened this issue Dec 10, 2020 · 5 comments · Fixed by #36
Assignees
Labels
bug Something isn't working

Comments

@AlbinLindskog
Copy link

cdp-cache does not handle non-200 responses correctly. The content of the response is handled correctly, but the status code is changed to 200.

Here is a bare-bones project that demonstrates the issue: https://github.com/AlbinLindskog/cpd-cache-bug

@sillygod sillygod added the bug Something isn't working label Dec 12, 2020
@sillygod
Copy link
Owner

Hi @AlbinLindskog ,

Thanks for filling this issue, I've made a PR( #36 ) to fix this bug.

@AlbinLindskog
Copy link
Author

Impressive! Speedy work. I've confirmed that it works in our setup.

Consider releasing a new version with this fix. xcaddy uses the latest version, not the latest commit, so anyone installing the with xcaddy will end up with 0.4.2, unless the explicitly specify the commit.

@sillygod
Copy link
Owner

Impressive! Speedy work. I've confirmed that it works in our setup.

Consider releasing a new version with this fix. xcaddy uses the latest version, not the latest commit, so anyone installing the with xcaddy will end up with 0.4.2, unless the explicitly specify the commit.

Sure, I will create a new release. thx.

@sillygod
Copy link
Owner

@AlbinLindskog ,

I've created a new release.

@sillygod sillygod self-assigned this Dec 13, 2020
@sillygod sillygod linked a pull request Dec 13, 2020 that will close this issue
@sillygod
Copy link
Owner

@AlbinLindskog ,

If it's no more problem, I will close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants