-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing/Breaking off Text.Tabular.AsciiWide. #1679
Comments
I've done a bit of looking in to table-layout, and there are a few questions we would need to answer before deciding whether migration is suitable. Blockers
Non-blockers, but significant formatting differences
If we were willing to accept a big change in how our tables were displayed then we could ignore any of these non-blockers. However, that would be a huge pain for upgrading the test suite, plus I like our current style. A decision needs to be made on whether pursuing a migration would be acceptable if any of these issues are unable to be resolved (because table-layout doesn't want to or can't implement the feature). |
I can see an easy way to implement this with styles and some help of type classes. If you're interested you can create an issue. I'm definitely willing to improve the usability. |
There have been calls at various points to break off AsciiWide and WideString into its own library (see e.g. #1136).
The functionality is completely independent of hledger, and making it available for re-use/decoupling the versions would be useful. AsciiWide also happens to add a surprising amount to build time (a little under 5s on my system), so splitting this off would help build times.
That said, AsciiWide may not be (is probably not) the best solution to the problem, and instead of reinventing the wheel maybe we want to adopt another solution. table-layout is a solution that people here have looked at before, and seems well-aligned to the job to be done. It also seems that it would make aligning on decimal points (a long-requested feature) easy. However, it does not seem to support wide characters (muesli4/table-layout#8). @ony and @simonmichael put in some effort to see if that could be added about a year and a half ago; maybe I could put out feelers to see if they are open to more work on that.
The text was updated successfully, but these errors were encountered: