Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require certain parameters, show UI if they are missing #2

Closed
simonw opened this issue Sep 18, 2019 · 2 comments
Closed

Require certain parameters, show UI if they are missing #2

simonw opened this issue Sep 18, 2019 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@simonw
Copy link
Owner

simonw commented Sep 18, 2019

Atom feed entries have some required content.

  • atom:id
  • atom:title
  • atom:updated
  • atom:content (unless you link to content instead)

We need to know which query columns should correspond to each of these fields.

We can accept these as ?_atom_id=xxx&_atom_updated=yyy and so-on - but what do we do if those parameters are missing?

Some of them we can guess (based on naming conventions, primary keys or Datasette's existing label detection mechanism and metadata.json configuration) - but what do we do if we can't guess them?

I'm going to fall back to returning an HTML page (with a invalid parameters 400 HTTP status code) that helps the user select the missing parameters.

@simonw simonw added the enhancement New feature or request label Sep 18, 2019
@simonw
Copy link
Owner Author

simonw commented Oct 5, 2019

WIP on this: c0e3bd9

@simonw
Copy link
Owner Author

simonw commented May 28, 2020

I'm not going to do this. I like the configuration-by-SQL-query mechanism better.

@simonw simonw closed this as completed May 28, 2020
@simonw simonw added the wontfix This will not be worked on label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant