Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure downloading a 100+MB SQLite database file works #398

Closed
simonw opened this issue Jan 10, 2019 · 3 comments
Closed

Ensure downloading a 100+MB SQLite database file works #398

simonw opened this issue Jan 10, 2019 · 3 comments
Labels
bug
Milestone
Datasette 1.0

Comments

@simonw
Copy link
Owner

simonw commented Jan 10, 2019

I've seen attempted downloads of large files fail after about ten seconds.
@simonw simonw added the bug label Jan 10, 2019
@simonw
Copy link
Owner Author

simonw commented Feb 6, 2019

I'd really like to use the content-length header here, but Sanic hasn't yet fixed the bug I filed about it: sanic-org/sanic#1194

@simonw
Copy link
Owner Author

simonw commented Jun 24, 2019

I no longer depend on Sanic so I should be able to solve this entirely within the Datasette codebase. I need to figure out how Transfer-Encoding: chunked and the Content-Length header interact.

@simonw simonw added this to the Datasette 1.0 milestone Jun 6, 2020
@simonw
Copy link
Owner Author

simonw commented Dec 5, 2020

This was fixed in #749 by 88ac538

@simonw simonw closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Datasette 1.0
Development

No branches or pull requests
1 participant
@simonw