Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"datasette plugins" command is broken #802

Closed
simonw opened this issue Jun 5, 2020 · 1 comment
Closed

"datasette plugins" command is broken #802

simonw opened this issue Jun 5, 2020 · 1 comment
Labels

Comments

@simonw
Copy link
Owner

simonw commented Jun 5, 2020

I broke it in a7137df - and it turns out there was no test coverage so I didn't realize it was broken.

@simonw simonw added the bug label Jun 5, 2020
@simonw
Copy link
Owner Author

simonw commented Jun 5, 2020

datasette/datasette/cli.py

Lines 126 to 129 in 033a1bb

def plugins(all, plugins_dir):
"List currently available plugins"
app = Datasette([], plugins_dir=plugins_dir)
click.echo(json.dumps(app.plugins(all), indent=4))

But I changed the .plugins() method to this:

datasette/datasette/app.py

Lines 628 to 633 in 033a1bb

def _plugins(self, request):
ps = list(get_plugins())
if not request.args.get("all"):
ps = [p for p in ps if p["name"] not in DEFAULT_PLUGINS]
return [

@simonw simonw closed this as completed in f786033 Jun 5, 2020
simonw added a commit that referenced this issue Jun 6, 2020
simonw added a commit that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant