Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop resource_type from permission_allowed system #817

Closed
simonw opened this issue Jun 8, 2020 · 1 comment
Closed

Drop resource_type from permission_allowed system #817

simonw opened this issue Jun 8, 2020 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented Jun 8, 2020

Current signature:

permission_allowed(datasette, actor, action, resource_type, resource_identifier)

It turns out the resource_type is always the same thing for any given action, so it's not actually useful. I'm going to drop it.

New signature will be:

permission_allowed(datasette, actor, action, resource)

Refs #811.

@simonw
Copy link
Owner Author

simonw commented Jun 8, 2020

I'm also going to rename resource_identifier to just resource.

@simonw simonw closed this as completed in c9f1ec6 Jun 8, 2020
simonw added a commit that referenced this issue Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant