{"$file": ...} mechanism is broken #839

simonw · 2020-06-12T00:46:24Z

https://travis-ci.org/github/simonw/datasette/jobs/697445318

    def test_plugin_config_file(app_client):
        open(TEMP_PLUGIN_SECRET_FILE, "w").write("FROM_FILE")
>       assert {"foo": "FROM_FILE"} == app_client.ds.plugin_config("file-plugin")
E       AssertionError: assert {'foo': 'FROM_FILE'} == {'foo': {'$fi...ugin-secret'}}
E         Differing items:
E         {'foo': 'FROM_FILE'} != {'foo': {'$file': '/tmp/plugin-secret'}}
E         Use -v to get the full diff

Broken in fba8ff6 as part of #837

The text was updated successfully, but these errors were encountered:

Refs #395, #519, #576, #699, #706, #774, #777, #781, #784, #788, #790, #797, #798, #800, #802, #804, #819, #822, #825, #826, #827, #828, #829, #830, #833, #836, #837, #839 Closes #806.

simonw added the bug label Jun 12, 2020

simonw added this to the Datasette 0.44 milestone Jun 12, 2020

simonw closed this as completed in 9ae0d48 Jun 12, 2020

simonw added a commit that referenced this issue Jun 12, 2020

Release Datasette 0.44

b906030

Refs #395, #519, #576, #699, #706, #774, #777, #781, #784, #788, #790, #797, #798, #800, #802, #804, #819, #822, #825, #826, #827, #828, #829, #830, #833, #836, #837, #839 Closes #806.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{"$file": ...} mechanism is broken #839

{"$file": ...} mechanism is broken #839

simonw commented Jun 12, 2020

{"$file": ...} mechanism is broken #839

{"$file": ...} mechanism is broken #839

Comments

simonw commented Jun 12, 2020